[lvm-devel] [PATCH 05/23] Replicator: suspend/deactivate replicator
Zdenek Kabelac
zkabelac at redhat.com
Wed Apr 28 12:27:24 UTC 2010
Introducing dm_tree_set_suspend_priority() for suspending replicator
control target before deactivation of replicator-dev target.
This patch presents no functional change to current dtree - only
replicator target currently sets higher suspend priority for some of its
nodes.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
libdm/.exported_symbols | 1 +
libdm/libdevmapper.h | 2 +
libdm/libdm-deptree.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 65 insertions(+), 0 deletions(-)
diff --git a/libdm/.exported_symbols b/libdm/.exported_symbols
index 090e633..84c216e 100644
--- a/libdm/.exported_symbols
+++ b/libdm/.exported_symbols
@@ -82,6 +82,7 @@ dm_tree_node_add_mirror_target_log
dm_tree_node_add_target_area
dm_tree_node_add_replicator_target
dm_tree_node_add_replicator_dev_target
+dm_tree_set_suspend_priority
dm_tree_node_set_read_ahead
dm_tree_skip_lockfs
dm_tree_use_no_flush_suspend
diff --git a/libdm/libdevmapper.h b/libdm/libdevmapper.h
index 02f4be0..c1945b3 100644
--- a/libdm/libdevmapper.h
+++ b/libdm/libdevmapper.h
@@ -474,6 +474,8 @@ int dm_tree_node_add_replicator_dev_target(struct dm_tree_node *node,
uint32_t slog_region_size);
/* End of Replicator API */
+int dm_tree_set_suspend_priority(struct dm_tree *dtree, const char *uuid, int priority);
+
int dm_tree_node_add_target_area(struct dm_tree_node *node,
const char *dev_name,
const char *dlid,
diff --git a/libdm/libdm-deptree.c b/libdm/libdm-deptree.c
index 6cbb806..b9e19f2 100644
--- a/libdm/libdm-deptree.c
+++ b/libdm/libdm-deptree.c
@@ -162,6 +162,7 @@ struct dm_tree_node {
struct dm_list used_by; /* Nodes that use this node */
int activation_priority; /* 0 gets activated first */
+ int suspend_priority; /* 1 gets suspend first */
uint16_t udev_flags; /* Udev control flags */
@@ -684,6 +685,18 @@ void dm_tree_node_set_read_ahead(struct dm_tree_node *dnode,
dnode->props.read_ahead_flags = read_ahead_flags;
}
+int dm_tree_set_suspend_priority(struct dm_tree *dtree, const char *uuid, int priority)
+{
+ struct dm_tree_node *dnode;
+
+ if ((dnode = dm_tree_find_node_by_uuid(dtree, uuid))) {
+ log_verbose("Setting suspend priority for %s.", dnode->name);
+ dnode->suspend_priority = priority;
+ }
+
+ return 1;
+}
+
int dm_tree_add_dev(struct dm_tree *dtree, uint32_t major, uint32_t minor)
{
return _add_dev(dtree, &dtree->root, major, minor, 0) ? 1 : 0;
@@ -1043,6 +1056,52 @@ static int _suspend_node(const char *name, uint32_t major, uint32_t minor,
return r;
}
+static int _suspend_parent(struct dm_tree_node *dnode, const char *uuid_prefix,
+ size_t uuid_prefix_len)
+{
+ struct dm_info info;
+ const struct dm_info *dinfo;
+ const char *name;
+ const char *uuid;
+ struct dm_tree_link *dlink;
+
+ dm_list_iterate_items(dlink, &dnode->uses) {
+ if (!dlink->node->suspend_priority)
+ continue;
+
+ if (!(uuid = dm_tree_node_get_uuid(dlink->node))) {
+ stack;
+ continue;
+ }
+ /* Ignore if it doesn't belong to this VG */
+ if (!_uuid_prefix_matches(uuid, uuid_prefix, uuid_prefix_len))
+ continue;
+
+ if (!(dinfo = dm_tree_node_get_info(dlink->node))) {
+ stack;
+ continue;
+ }
+
+ if (dinfo->suspended)
+ continue;
+
+ if (!(name = dm_tree_node_get_name(dlink->node))) {
+ stack;
+ continue;
+ }
+
+ if (!_suspend_node(name, dinfo->major, dinfo->minor,
+ 1, 1, &info)) {
+ log_error("Unable to suspend %s (%" PRIu32
+ ":%" PRIu32 ").", name, dinfo->major,
+ dinfo->minor);
+ return 0;
+ }
+ }
+
+ return 1;
+}
+
/*
* FIXME Don't attempt to deactivate known internal dependencies.
*/
@@ -1095,6 +1154,9 @@ static int _dm_tree_deactivate_children(struct dm_tree_node *dnode,
continue;
}
+ if (!_suspend_parent(child, uuid_prefix, uuid_prefix_len))
+ continue;
+
if (!_deactivate_node(name, info.major, info.minor,
&child->dtree->cookie, child->udev_flags)) {
log_error("Unable to deactivate %s (%" PRIu32
--
1.7.0.1
More information about the lvm-devel
mailing list