[lvm-devel] "lv_attr" disappeared from lvm_lv_get_property?

Marius Vollmer marius.vollmer at redhat.com
Thu Jan 29 20:24:28 UTC 2015


Alasdair G Kergon <agk at redhat.com> writes:

> On Thu, Jan 29, 2015 at 09:50:08PM +0200, Marius Vollmer wrote:
>> at one moment lvm_lv_get_property returned a valid and useful "lv_attr"
>> property, and then suddenly it returns values with "is_valid == 0".
>
> The way some of the properties are gathered got changed.
>
> Sounds like we forgot to update the library code to use the new method...

I found this:

    /* backward compatible internal API for lvm2api, TODO improve it */
    char *lv_attr_dup(struct dm_pool *mem, const struct logical_volume *lv)

Guys, really.  Write some tests.




More information about the lvm-devel mailing list