[Ovirt-devel] [Patch] History Graphs Axis

[mark wagner]

Well, I'm not really happy with this, it doesn't address some of the issues that you claimed, but it 
doesn't really break anything either and it applied cleanly. If it was early in the devel cycle I 
would ack it and then we can just fix the remaining stuff including some visual things introduced 
here. However, if it was against a BZ and you didn't satisfy all of the BZ it would be NACK'd

Also, the fact that this patch is depends on a previous patch of yours and there is a follow on 
patch to correct something in this patch concerns me.  We almost need to start acking things in 
order to not get messed up or lose work.

Hugh, Perry, should we be modifying the criteria as we get closer to beta ?
Any comments / suggestions on how to proceed?


-mark


Mohammed Morsi wrote:
> Mohammed Morsi wrote:
>> Added meaningful axis to the history graph. Took longer than planned 
>> due to a latent bug in out central layouts/_graph.rhtml component that 
>> I had to figure out a work around for.
>>
>>   -Mo
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Ovirt-devel mailing list
>> Ovirt-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/ovirt-devel
> More fixes to the axis, and integrated Mark's changes for the peak 
> history, while adding logic for the peak snapshot indicators.
> 
>    -Mo
>