[Ovirt-devel] [PATCH] Users are displayed from LDAP and filtered based on the current list of users.

[Darryl L. Pierce]

On Monday 19 May 2008 09:46:47 am Scott Seago wrote:
> Do you really need a class variable here? This could cause unnecessary
> concurrency problems. Since you aren't referencing it anywhere else why
> not just a plain local variable?

It was for performance -- since I don't expect LDAP to change frequently, the 
goal there was to cache the list of names as a class variable and refer to 
that for future calls. The LDAP hit is somewhat costly, on the order of 
several seconds, to pull down the list of names.

-- 
Darryl L. Pierce <dpierce at redhat.com> - Phone: (919) 754-4383
"In matters of style, swim with the current; 
In matters of principle, stand like a rock." - Thomas Jefferson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080519/b9183d98/attachment.sig>