[Ovirt-devel] [PATCH] Users are displayed from LDAP and filtered based on the current list of users.
Scott Seago
sseago at redhat.com
Mon May 19 14:22:50 UTC 2008
Darryl L. Pierce wrote:
> On Monday 19 May 2008 09:46:47 am Scott Seago wrote:
>
>> Do you really need a class variable here? This could cause unnecessary
>> concurrency problems. Since you aren't referencing it anywhere else why
>> not just a plain local variable?
>>
>
> It was for performance -- since I don't expect LDAP to change frequently, the
> goal there was to cache the list of names as a class variable and refer to
> that for future calls. The LDAP hit is somewhat costly, on the order of
> several seconds, to pull down the list of names.
>
>
True enough, although how do we deal w/ ldap updates? Do we force reload
of this periodically -- and if so, do we do this outside of a WUI page
request, so the user isn't hit waiting for this?
Scott
More information about the ovirt-devel
mailing list