[Ovirt-devel] [PATCH] Modified LDAPConnection to work with an SRV record, then fallback to the ldap.yml file if necessary.

[Perry N. Myers]

Darryl L. Pierce wrote:
> ---
>  wui/src/app/controllers/hardware_controller.rb |    2 +-
>  wui/src/app/helpers/ldap_connection.rb         |   25 ++++++++++++++++++-----
>  wui/src/app/models/account.rb                  |    2 +-
>  3 files changed, 21 insertions(+), 8 deletions(-)

There are still references in the source tree to 
ActiveLdap::Base.establish_connection, which uses the data from the 
ldap.yml file.

As far as I can tell, nothing in the source tree even uses this 
LDAPConnection class.  (Granted, I know nothing about Ruby.  I just did a 
grep for LDAPConnection and nothing came up except for ldap_connection.rb)

account.rb says:
   # This API requires that a previous connection be made using
   # +LDAPConnection.connect+.

But nothing seems to call LDAPConnection.connect

So how is this supposed to work?

NACK until these issues are corrected.

Perry