[Ovirt-devel] Re: Modified LDAPConnection to work with an SRV record, then fallback to the ldap.yml file if necessary.

[Darryl L. Pierce]

+++ Perry N. Myers [22/05/08 19:40 -0400]:
> Darryl L. Pierce wrote:
>> ---
>>  wui/src/app/controllers/hardware_controller.rb |    2 +-
>>  wui/src/app/helpers/ldap_connection.rb         |   25 ++++++++++++++++++-----
>>  wui/src/app/models/account.rb                  |    2 +-
>>  3 files changed, 21 insertions(+), 8 deletions(-)
>
> There are still references in the source tree to 
> ActiveLdap::Base.establish_connection, which uses the data from the 
> ldap.yml file.
>
> As far as I can tell, nothing in the source tree even uses this 
> LDAPConnection class.  (Granted, I know nothing about Ruby.  I just did a 
> grep for LDAPConnection and nothing came up except for ldap_connection.rb)

grant_admin_privileges calls LDAPConnection.connect to establish a connection
prior to confirming the uid is valid.

> account.rb says:
>   # This API requires that a previous connection be made using
>   # +LDAPConnection.connect+.
>
> But nothing seems to call LDAPConnection.connect
>
> So how is this supposed to work?

I'll fix this and resend a patch today.

-- 
Darryl L. Pierce <dpierce at redhat.com> - Phone: (919) 754-4383
Sr. Software Engineer -- Red Hat, Inc.
"In matters of style, swim with the current; 
In matters of principle, stand like a rock." - Thomas Jefferson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080523/6d49dab3/attachment.sig>