[Ovirt-devel] [PATCH ovirt-node-image] build procedure change: include image ISO in SRPM

[Daniel P. Berrange]

On Tue, Nov 04, 2008 at 03:40:14PM +0100, Alan Pevec wrote:
> livecd images cannot be built in Koji build-system at the moment,
> they need to be included in SRPM
> 
> Signed-off-by: Alan Pevec <apevec at redhat.com>

NACK.

In doing this you are no longer testing ISO image creation in
the automated builds.

The existing core functionality of the SPEC file shouldn't
be removed.

There should be a conditional in the spec file to let you
optionally build the RPM with a pre-built ISO.

Or if that's too complex, create a separate 'ovirt-node-image-prebuilt.spec'
which has a 'Provides: ovirt-node-image' in it.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|