[Ovirt-devel] Re: [PATCH appliance] Move appliance creation out of spec file to Makefile

[Perry Myers]

Alan Pevec wrote:
> Perry Myers wrote:
>> -ln -s %{ovirt_cache_dir}/appliance-tmp tmp
>> +    ln -s $(OVIRT_CACHE_DIR)/$(PACKAGE)-tmp tmp
> 
> ln -snf ... otherwise it fails 2nd time

I stole that from your Makefile in ovirt-node :)  So it'll need to be 
fixed there as well.

> prolly not worth optimizing, but due to tmpdir name change 
> (appliance-tmp -> ovirt-appliance-tmp) Fedora image will be 
> re-downloaded ( ~100MB )

Yeah, it's a one time thing.  And if someone is concerned they can just 
move appliance-tmp to ovirt-appliance-tmp.

> 
>> -sudo su - -c "cd $(pwd) && appliance-creator --config 
>> ovirt-appliance.ks \
>> +    sudo -E appliance-creator --config $(PACKAGE).ks \
> 
> appliance-creator assumes grub in PATH, so this fails when installing 
> grub. Until appliance-tools is fixed, workaround could be to modify PATH 
> before running sudo
> 

Odd, I didn't have any problems with this.  Probably because I have /sbin 
in my build user's path.  I'll add PATH setting to the Makefile to fix this.

Perry

-- 
|=-        Red Hat, Engineering, Emerging Technologies, Boston        -=|
|=-                     Email: pmyers at redhat.com                      -=|
|=-         Office: +1 412 474 3552   Mobile: +1 703 362 9622         -=|
|=- GnuPG: E65E4F3D 88F9 F1C9 C2F3 1303 01FE 817C C5D2 8B91 E65E 4F3D -=|