[Ovirt-devel] [PATCH server] Revised attempt at refactoring the vm_controller using the service layer.

Scott Seago sseago at redhat.com
Wed Apr 22 18:26:49 UTC 2009


David Lutterkort wrote:
> On Wed, 2009-04-22 at 14:19 -0400, Scott Seago wrote:
>   
>> For edits you only need to include changed attributes in the hash. So 
>> you could call svc_obj.svc_update(vm_id, {:description => 'changed 
>> description'}).
>>     
>
> Yeah, that makes much more sense than my implict assumption that we have
> a special method to modify single properties.
>
>   
Maybe there's value for the single property version -- I"m not sure.
>> I'm still slightly confused on how VmDef relates to the service classes. 
>> Is VmDef the class that includes the VmService module? Or is VmDef 
>> something longer-lived and more related to the activerecord stuff directly?
>>     
>
> IIRC VmDef is the QMF object that is exposed for a Vm, i.e. the QMF
> 'view' of a virtual machine, not the controller.
>
> David
>
>   
So we have two different QMF objects for each AR type? i.e. for Foo we 
have FooDef which maps to AR and FooService which maps to the 
service/controller layer? Does it matter that FooService ignores FooDef 
and uses the AR Foo class directly?

Scott




More information about the ovirt-devel mailing list