[Ovirt-devel] [PATCH server] controller service layer refactoring for pools.

[David Lutterkort]

On Wed, 2009-04-29 at 23:54 -0400, Scott Seago wrote:
> I guess I'm not sure what the right solution is. On one hand we don't 
> want to lose information on what was  thrown originally. On the other 
> hand PartialSuccessError gives the impression from its embedded 
> successes/failures attributes that part of the action succeeded. In this 
> particular case, though, where these multi-object actions are executed 
> as part of a create operation, we're explicitly aborting the 
> transaction, so passing the PartialSuccessError up would _also_ give a 
> false impression, namely that error.successes did indeed get committed 
> to the database. This is starting to sound a bit absurd, but we could 
> always create an AbortedPartialSuccessError (possibly extending 
> ActionError) class that contains a reference to the thrown 
> PartialSuccessError exception. That would resolve the exception 
> swallowing inaccuracies _and_ the no-longer-accurate partial success 
> notification, but it's not the most elegant solution.

Yeah, you are right, it would change the meaning of PartialSuccessError
- for now, probably best to stick with the ActionError.

Though I would find a flow where both move to an existing pool and move
to a new pool failed in similar ways.

David