[Ovirt-devel] [PATCH node] fix /var/log persistence

[Darryl L. Pierce]

On Tue, Feb 24, 2009 at 02:14:57AM +0100, Alan Pevec wrote:
> copy initial logs from tmpfs to HostVG/Logging
> use lsof to find services with opened logfiles
> 
> Signed-off-by: Alan Pevec <apevec at redhat.com>
> ---
>  scripts/ovirt-functions |   42 +++++++++++++++++++++++++++++++++++++-----
>  1 files changed, 37 insertions(+), 5 deletions(-)

ACK with one comment/question.

>  # mount logging partition
> +# this only gets executed when disk is re-partitioned, HostVG/Logging is empty
>  mount_logging() {
>      if grep -q " /var/log ext3" /proc/mounts; then
>          return 0
> @@ -286,11 +302,21 @@ mount_logging() {
>      if [ -e /dev/HostVG/Logging ] ; then
>          log "Mounting log partition"
>  
> -        mount /dev/HostVG/Logging /var/log
> +        # temporary mount-point
> +        mkdir -p /var/log2

Would it be better to use mktemp -d here to generate a path name?

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090224/d0175cb3/attachment.sig>