[Ovirt-devel] [PATCH node] fix /var/log persistence
Alan Pevec
apevec at gmail.com
Tue Feb 24 19:49:57 UTC 2009
On Tue, Feb 24, 2009 at 4:36 PM, Darryl L. Pierce <dpierce at redhat.com> wrote:
>> + mkdir -p /var/log2
>
> Would it be better to use mktemp -d here to generate a path name?
yes, here's incremental diff (I'll push amended patch)
diff --git a/scripts/ovirt-functions b/scripts/ovirt-functions
index ba11856..6ee8940 100755
--- a/scripts/ovirt-functions
+++ b/scripts/ovirt-functions
@@ -303,16 +303,18 @@ mount_logging() {
log "Mounting log partition"
# temporary mount-point
- mkdir -p /var/log2
- mount /dev/HostVG/Logging /var/log2
+ log2=$(mktemp -d)
+ mkdir -p $log2
+ mount /dev/HostVG/Logging $log2
unmount_logging_services
# save logs from tmpfs
- cp -av /var/log/* /var/log2
+ cp -av /var/log/* $log2
# save temporary log
if [ -e /tmp/ovirt.log ]; then
- cp /tmp/ovirt.log /var/log2/ovirt.log-tmp
+ cp /tmp/ovirt.log $log2/ovirt.log-tmp
fi
- mount --move /var/log2 /var/log
+ mount --move $log2 /var/log
+ rmdir $log2
restorecon -rv /var/log
for srv in $services; do
service $srv start
More information about the ovirt-devel
mailing list