[Ovirt-devel] [PATCH node] Cleaned up the input prompts when configuring partitions.
Perry Myers
pmyers at redhat.com
Tue Jan 27 16:19:26 UTC 2009
Darryl L. Pierce wrote:
> Prompts were putting the question mark on a separate line from the
> prompt. This patch moves it to the end of the line with the prompt.
>
> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
> ---
> scripts/ovirt-config-storage | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
> index 45355fd..b096a57 100755
> --- a/scripts/ovirt-config-storage
> +++ b/scripts/ovirt-config-storage
> @@ -174,10 +174,8 @@ do_configure()
> eval "min_size=\$$min_size_var"
>
> while true; do
> - printf "\nChange $part partition size. (Def. $size MB), "
> - printf "Min. $min_size MB, "
> - printf "Max. ~$space_left MB)\n"
> - read -ep "? "
> + printf "\n"
> + read -ep "Change $part partition size. (Def. $size MB), Min. $min_size MB, Max. ~$space_left MB)? "
Does this all fit on one line with user input? or does it cause the user
to wrap to the next line while they are entering input?
Also, you have an extra ) after $size MB
Perry
More information about the ovirt-devel
mailing list