[Ovirt-devel] [PATCH node] Cleaned up the input prompts when configuring partitions.

Darryl L. Pierce dpierce at redhat.com
Tue Jan 27 18:34:07 UTC 2009


On Tue, Jan 27, 2009 at 11:19:26AM -0500, Perry Myers wrote:
> Darryl L. Pierce wrote:
>> Prompts were putting the question mark on a separate line from the
>> prompt. This patch moves it to the end of the line with the prompt.
>>
>> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
>> ---
>>  scripts/ovirt-config-storage |    6 ++----
>>  1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
>> index 45355fd..b096a57 100755
>> --- a/scripts/ovirt-config-storage
>> +++ b/scripts/ovirt-config-storage
>> @@ -174,10 +174,8 @@ do_configure()
>>          eval "min_size=\$$min_size_var"
>>           while true; do
>> -            printf "\nChange $part partition size. (Def. $size MB), "
>> -            printf "Min. $min_size MB, "
>> -            printf "Max. ~$space_left MB)\n"
>> -            read -ep "? "
>> +	    printf "\n"
>> +            read -ep "Change $part partition size. (Def. $size MB), Min. $min_size MB, Max. ~$space_left MB)? "
>
> Does this all fit on one line with user input?  or does it cause the user 
> to wrap to the next line while they are entering input?

Yes, it does all fit on the line even if the user puts in a 7 digit
partition size.


-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
"What do you care what other people think, Mr. Feynman?"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090127/b2723f22/attachment.sig>


More information about the ovirt-devel mailing list