[Ovirt-devel] [PATCH node] Cleaned up the input prompts when configuring partitions.

[Perry Myers]

Darryl L. Pierce wrote:
> On Tue, Jan 27, 2009 at 11:19:26AM -0500, Perry Myers wrote:
>> Darryl L. Pierce wrote:
>>> Prompts were putting the question mark on a separate line from the
>>> prompt. This patch moves it to the end of the line with the prompt.
>>>
>>> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
>>> ---
>>>  scripts/ovirt-config-storage |    6 ++----
>>>  1 files changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
>>> index 45355fd..b096a57 100755
>>> --- a/scripts/ovirt-config-storage
>>> +++ b/scripts/ovirt-config-storage
>>> @@ -174,10 +174,8 @@ do_configure()
>>>          eval "min_size=\$$min_size_var"
>>>           while true; do
>>> -            printf "\nChange $part partition size. (Def. $size MB), "
>>> -            printf "Min. $min_size MB, "
>>> -            printf "Max. ~$space_left MB)\n"
>>> -            read -ep "? "
>>> +	    printf "\n"
>>> +            read -ep "Change $part partition size. (Def. $size MB), Min. $min_size MB, Max. ~$space_left MB)? "
>> Does this all fit on one line with user input?  or does it cause the user 
>> to wrap to the next line while they are entering input?
> 
> Yes, it does all fit on the line even if the user puts in a 7 digit
> partition size.
> 
> 

ok, then ACK as long as you fix the extra paren :)

Perry

-- 
|=-        Red Hat, Engineering, Emerging Technologies, Boston        -=|
|=-                     Email: pmyers at redhat.com                      -=|
|=-         Office: +1 412 474 3552   Mobile: +1 703 362 9622         -=|
|=- GnuPG: E65E4F3D 88F9 F1C9 C2F3 1303 01FE 817C C5D2 8B91 E65E 4F3D -=|