[Patchew-devel] Patchew code style and patch submission

Caio Carrara ccarrara at redhat.com
Tue Nov 6 17:43:39 UTC 2018


Hello, Patchew devs!

I'm willing to start some contributions to patchew and reading the code
I saw it's not following the PEP8[1] recommendations. Is it intendend
for any reason? If it's not intentional I would like to submit some
patches applying the PEP8 standards and in a near future we could even
integrate the lint check in Patchew CI.

It's important to see that with simple lint checks we can get some cases
like this one[2] where a variable is created but unused and a database
query is done unnecessarily. I've already applied the PEP8 rules in some
files locally and others minor refactorings can improve readability.

Besides that, what is the expected approach to submit a patch: here in
this mailing list or in GitHub pull request?

Thanks,

[1] - https://www.python.org/dev/peps/pep-0008/
[2] - https://github.com/patchew-project/patchew/blob/master/api/views.py#L135
-- 
Caio Carrara
Software Engineer, Virt Team - Red Hat
ccarrara at redhat.com




More information about the Patchew-devel mailing list