[Patchew-devel] Patchew code style and patch submission

[Paolo Bonzini]

On 06/11/2018 18:43, Caio Carrara wrote:
> 
> I'm willing to start some contributions to patchew and reading the code
> I saw it's not following the PEP8[1] recommendations. Is it intendend
> for any reason? If it's not intentional I would like to submit some
> patches applying the PEP8 standards and in a near future we could even
> integrate the lint check in Patchew CI.

Not at all intentional, go ahead.  Neither Fam nor I are experienced
Python developers.

> It's important to see that with simple lint checks we can get some cases
> like this one[2] where a variable is created but unused and a database
> query is done unnecessarily. I've already applied the PEP8 rules in some
> files locally and others minor refactorings can improve readability.
> 
> Besides that, what is the expected approach to submit a patch: here in
> this mailing list or in GitHub pull request?

It's the same.  We tend to use the mailing list in the interest of
dogfooding, but that's it.

Paolo