[Pki-devel] [PATCH] 170-172 formatting and improvements to security domain python api

[Abhishek Koneru]

Few comments:
170:
-- Variable Names - replace camelCase with _separated_words (All weak
warnings reported by PyCharm)

  Since the objects of KeyData, KeyInfo, KeyRequestInfo,
KeyRequestResponse have only client side use, we can set the attribute
names as _separated_words in the from_json method of these classes.

-- Replacing the get methods in KeyInfo and KeyRequestInfo to property
type

@property
def request_id(self):
    if self.requestURL is not None:
        indx = str(self.requestURL).rfind("/") + 1
        return str(self.requestURL)[indx:]
    return None

171 - 
-- class ConfigurationRequest.
   we can use setattr(), so that PyCharm does not throw the weak
errors.(Optional. It is your call. I think this is an internal class.)

Other than that. ACK from me for all three patches.

--Abhishek
   

On Fri, 2014-05-09 at 09:41 -0400, Ade Lee wrote:
> Added security domain functionality to python API
>     
>     Currently the security domain python API just extracts the security
>     domain name from the json returned by the server.  This patch allows
>     it to extract and use all the information in the response.
>     
>     This info is needed to determine the state of the security domain for
>     the IPA vault case.
> 
> Also I started using pycharm (and its awesome - I think we all should use it for python work)
> and it identified a bunch of formatting etc. issues. Those are fixed for system.py and key.py.
> 
> Please review,
> Ade
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel