[Pulp-dev] Pull Request builder job changes for plugins

Brian Bouterse bbouters at redhat.com
Fri Jun 2 21:06:59 UTC 2017

That is a good point, and one we are giving some thought to through convo
on #pulp-dev and the issue [0]. The case of a plugin needing an unreleased
change from core would fail with this change. It's a tradeoff though
because if we go with nightlies as the version of core that is used,
whenever the nightlies break, the unittest PR runners also will, which has
been a reliability issue with the plugin unittest runner for a while.

I wrote some on the issue about it, but I see the 'plugin needs unreleased
code from core' as a special case, not a normal case. It used to be common,
but it's getting less common, which is good, because contributing to a
plugin should not involve changes to the core as the norm. It will happen
from time to time, so we can handle the special case, specially by running
the unittests locally with the necessary unreleased version of platform and
posting the results as evidence that its safe to merge.

[0]: https://pulp.plan.io/issues/2751

On Fri, Jun 2, 2017 at 4:43 PM, Michael Hrivnak <mhrivnak at redhat.com> wrote:

> What about cases where a plugin wants to use something that's new in the
> unreleased core? The master branch of a plugin will usually be released
> with the master branch of the core in the next 2.y release for example.
> That seems like a normal scenario; is it facilitated somehow with this
> testing change?
> On Fri, Jun 2, 2017 at 4:33 PM, Dennis Kliban <dkliban at redhat.com> wrote:
>> In an effort to resolve issue 2751[0], I updated the PR builder job for
>> plugins. Each PR for a plugin will now be tested against the latest stable
>> release of the core found here[1]. This will ensure that the plugin is
>> maintaining compatibility with the latest stable core and that we are only
>> testing one change at a time.
>> [0] https://pulp.plan.io/issues/2751
>> [1] https://repos.fedorapeople.org/pulp/pulp/stable/latest/
>> -Dennis
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
> --
> Michael Hrivnak
> Principal Software Engineer, RHCE
> Red Hat
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20170602/4b03da80/attachment.htm>

More information about the Pulp-dev mailing list