mikedep333 at redhat.com
Tue Jun 4 17:14:22 UTC 2019
On Tue, Jun 4, 2019 at 12:09 PM Robin Chan <rchan at redhat.com> wrote:
> Mike, clarification question below...
> On Tue, Jun 4, 2019 at 11:45 AM Mike DePaulo <mikedep333 at redhat.com>
>> On Tue, Jun 4, 2019 at 9:14 AM Brian Herring <bherring at redhat.com> wrote:
>>> > Moreover, using black would effectively take style comments/noise out
>>> of PR reviews and we could just focus on logic.
>>> QE looked into this for a while, and I think it is a WONDERFUL
>>> addition... especially for the reasons stated above.
>>> Some tweaking would be needed, but it is one less item to worry about.
>> +1 based on my experiences on the X2Go project.
>> We don't want to turn off new contributors with style issues.
> Meaning new contributors would be annoyed that PR reviews would be full of
> stylistic comments and that would be a bad experience?
> I read this as possibly meaning new contributors would be unhappy with the
> black project style choices? Being unfamiliar with the X2Go project, I'd
> like some clarification on your input to the discussion here. TIA.
The former. New contributors being annoyed by stylistic comments.
I think they would likely be unhappy with the black project style choices
as well, but that would be outweighed.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pulp-dev