[Pulp-dev] black

[David Davis]

Flake8 is a wrapper for pycodestyle, pyflakes, and mccabe. We probably
could just use the last two without pycodestyle. That said I lean toward
just keeping flake8 I suppose. It makes some of the configuration stuff
easy.

David


On Thu, Jun 27, 2019 at 3:12 PM Bruno Rocha <brocha at redhat.com> wrote:

> If you set pre-commit hooks it is possible to have flake-8 to be executed
> automatically after black format.
>
> example:
> https://github.com/rochacbruno/dynaconf/blob/master/.pre-commit-config.yaml#L31
>
>
> Bruno Rocha
>
> Senior Quality Engineer - Cloud Management QE - Pulp Project
> *irc*: rochacbruno
>
> *social*: http://about.me/rochacbruno
>
> “Progress is the realization of utopia.”
> <https://red.ht/sig>
>
>
> On Thu, Jun 27, 2019 at 3:59 PM Simon Baatz <gmbnomis at gmail.com> wrote:
>
>> On Thu, Jun 27, 2019 at 07:58:38AM -0400, David Davis wrote:
>> >    Follow up question to adding support for black: should we drop
>> flake8?
>> >    We shouldn't need it anymore since black is pep8 compliant but I'm
>> >    happy to keep it around at least temporarily if people prefer?
>>
>> Please do not drop it. While black is pep8 compliant, flake8 does
>> more than pure code formatting checks. For example, the
>> following code is absolutely fine for black:
>>
>>    import os
>>
>>    d = {1: 2, 1: 3}
>>
>>
>> flake8 will complain about the unused import and the problem with the
>> dict keys.
>>
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20190627/4bf739e9/attachment.htm>