[Pulp-dev] PR Processor

[David Davis]

After looking at some different options last night, I think a cron job is
the only option. I opened this PR which has a scheduled job that should
check for new PRs every 5 min:

https://github.com/pulp/pulp-ci/pull/701

David


On Mon, Mar 23, 2020 at 4:27 PM David Davis <daviddavis at redhat.com> wrote:

> I ran into a problem. Any PR event in Github Actions runs against the fork
> and not the repo against which the PR was opened. And the repo's secrets
> such as the github api key and redmine api key are not shared with the fork
> for obvious security reasons. Fabricio and I are looking at some options.
> I'll try to figure out a workaround this coming weekend.
>
> David
>
>
> On Mon, Mar 23, 2020 at 9:19 AM David Davis <daviddavis at redhat.com> wrote:
>
>> Cool. When we move the cherry pick processor to Github Actions, we can do
>> some cool things like run it when a PR gets merged or labeled.
>>
>> David
>>
>>
>> On Mon, Mar 23, 2020 at 9:08 AM Brian Bouterse <bmbouter at redhat.com>
>> wrote:
>>
>>> Oh I'm glad you asked. I incorrectly thought this also actually
>>> performed cherry picking, but I see now it only adds labels. At one point
>>> we had the idea to convert the PR processor to a "run as needed with github
>>> actions" instead of "run once a day with Travis".
>>>
>>> I was referring to removing the cherry picking tooling from Travis, but
>>> if this doesn't replace it, let's not do that.
>>>
>>> On Mon, Mar 23, 2020 at 9:05 AM David Davis <daviddavis at redhat.com>
>>> wrote:
>>>
>>>> Brian,
>>>>
>>>> What do you mean by "removing the old one"? AFAIK, there is nothing
>>>> currently processing PRs and updating redmine.
>>>>
>>>> David
>>>>
>>>>
>>>> On Mon, Mar 23, 2020 at 8:41 AM Brian Bouterse <bmbouter at redhat.com>
>>>> wrote:
>>>>
>>>>> This is excellent. +1 to merging, rolling out to plugins, and removing
>>>>> the old one.
>>>>>
>>>>> Thank you!
>>>>>
>>>>> On Mon, Mar 23, 2020 at 7:48 AM Ina Panova <ipanova at redhat.com> wrote:
>>>>>
>>>>>> Thank you for this work!
>>>>>>
>>>>>>
>>>>>> --------
>>>>>> Regards,
>>>>>>
>>>>>> Ina Panova
>>>>>> Senior Software Engineer| Pulp| Red Hat Inc.
>>>>>>
>>>>>> "Do not go where the path may lead,
>>>>>>  go instead where there is no path and leave a trail."
>>>>>>
>>>>>>
>>>>>> On Sat, Mar 21, 2020 at 3:49 PM Daniel Alley <dalley at redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>> This is great!   Awesome work, David <3
>>>>>>>
>>>>>>> On Sat, Mar 21, 2020 at 10:38 AM David Davis <daviddavis at redhat.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> I created a PR workflow in Github Actions so I could learn more
>>>>>>>> about Github Actions.
>>>>>>>>
>>>>>>>> Here's the issue and my PR against plugin_template:
>>>>>>>>
>>>>>>>> https://pulp.plan.io/issues/4365
>>>>>>>> https://github.com/pulp/plugin_template/pull/199
>>>>>>>>
>>>>>>>> The PR processor will listen for new PRs in Github and when it
>>>>>>>> detects a newly opened PR it does two things:
>>>>>>>>
>>>>>>>> - Updates the pulp.plan.io issue
>>>>>>>>   - Adds a comment with a link to the Github PR (regardless of the
>>>>>>>> issue's status)
>>>>>>>>   - Sets the issue status to POST if it's in NEW or ASSIGNED
>>>>>>>> - Adds labels to the Github PR
>>>>>>>>   - Right now, this is only "Needs Cherry Pick" which is added if
>>>>>>>> tracker == "Issue"
>>>>>>>>
>>>>>>>> I have an example that demonstrates the PR processor. Here's a
>>>>>>>> story and its PR:
>>>>>>>>
>>>>>>>> https://pulp.plan.io/issues/6381
>>>>>>>> https://github.com/daviddavis/pulp_file/pull/11
>>>>>>>>
>>>>>>>> The PR processor will also comment with a warning if there is no
>>>>>>>> issue attached:
>>>>>>>>
>>>>>>>> https://github.com/daviddavis/pulp_file/pull/12
>>>>>>>>
>>>>>>>> Questions and feedback welcome.
>>>>>>>>
>>>>>>>> David
>>>>>>>> _______________________________________________
>>>>>>>> Pulp-dev mailing list
>>>>>>>> Pulp-dev at redhat.com
>>>>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Pulp-dev mailing list
>>>>>>> Pulp-dev at redhat.com
>>>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>>>>>
>>>>>> _______________________________________________
>>>>>> Pulp-dev mailing list
>>>>>> Pulp-dev at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>>>>
>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20200324/74cd3134/attachment.htm>