[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [scl.org] sclo-mod_auth_mellon ( was Re: Self-introduction)



Le 27/01/2016 09:06, Jarek Polok a écrit :
> Ok, thanks Remi! : I believe that this spec shall work:
> 
> https://github.com/jaroslawp/sclo-mod_auth_mellon/blob/master/mod_auth_mellon.spec

Few comments:

- missing sources in github (so I have used fedora ones for test)

- tmpfile stuff can be removed (run is not dynamic with SCL, and also
not needed on EL-6)

- /run (EL-7) vs /var/run  (EL-6)

- doesn't build (mock), "Could not find apsx2" during configure
  suggests using the --with-apxs2 option (or enabling the SCL)

- %{scl:%_scl_root} => %{?_scl_root}   (only cleaner, imho)

- missing arched virtual provide

  Provides: %{?scl_prefix}mod_auth_mellon = %{version}-%{release}
  Provides: %{?scl_prefix}mod_auth_mellon%{_isa} = %{version}-%{release}



With everything fixed, build ok, and content / requires / provides seems ok


Remi



-- 
rcollet redhat com | Senior Software Engineer / BaseOS / WebStack team
GPG Key: 0x29F16A18
Fingerprint: 5A0E 6F54 D94D 5732 69EE  E3FF 614A 6905 29F1 6A18


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]