[sos-devel] [PATCH 1/2] [plugin] allow reverse ordering in add_copy_spec_limit

Bryn M. Reeves bmr at redhat.com
Tue Aug 19 12:11:58 UTC 2014


On Tue, Aug 19, 2014 at 12:56:03PM +0200, Sandro Bonazzola wrote:
> A third option is for one-time log file, logging a single execution of a program.
> For example, ovirt-hosted-engine-setup (but also ovirt-engine-setup, ovirt-iso-uploader and probably a lot of other commands) generate a log file at
> each execution.

Which is the same as a non-rotated log file.. ('a.log' or 'b' above).
 
> If you don't want to sort by file name, a better way may be sorting by file mtime.

I think you misunderstood me. I'm not saying don't sort; I'm saying don't put
sorting under the control of the caller.

We should always sort consistently so that the ordering of glob.glob() results
and directory entries do not affect the behaviour.

Regards,
Bryn.




More information about the sos-devel mailing list