[sos-devel] [PATCH 1/2] [plugin] allow reverse ordering in add_copy_spec_limit

Bryn M. Reeves bmr at redhat.com
Thu Aug 28 09:09:48 UTC 2014


On Tue, Aug 19, 2014 at 11:05:36AM +0200, Sandro Bonazzola wrote:
> Added parameter to add_copy_spec_limit for allowing
> to use reverse ordering while collecting files.
> Without this time-stamped log files will be collected
> always starting from oldest so most recent logs wasn't
> in the report.

I've given this some more thought and have filed Issue #383 on github:

  https://github.com/sosreport/sos/issues/383

Looking at the different glob orders and the results of applying a
lexical sort I don't see a way to give the 'natural' ordering of
files that users expect using a simple file name based sort.

For now I'll apply the remaining patches as-is but we'll likely
switch the copy spec handlers to use a single common sort order
using the inode timestamps rather than path names.

Cheers,
Bryn.




More information about the sos-devel mailing list