[virt-tools-list] [virt-manager PATCH] tests: fix TestCapabilities.testCPUMap

Roman Bogorodskiy bogorodskiy at gmail.com
Tue Apr 8 16:08:18 UTC 2014

  Giuseppe Scrivano wrote:

> Roman Bogorodskiy <bogorodskiy at gmail.com> writes:
> >> commit 81696a514441f2320ea10299e1852795f8cb1682 removed the cpu_filename
> >> optional argument from the CPUValues constructor.  Maybe we
> >> should revert partly that commit and pass cpu_filename trough __init__
> >> again?
> >
> > That could be an option as well, but it seems we'll have to pass
> > cpu_filename all the way down from capabilities.Capabilities as we don't
> > instantiate _CPUMapFileValues directly from the test.
> ouch, that is true, though we should really test both implementations
> (and the wrapper function itself).  In any case that is out of the scope
> of this patch and we can fix it later.
> ACK.

Could you push if it's OK?

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140408/9b7a8415/attachment.sig>

More information about the virt-tools-list mailing list