[virt-tools-list] [virt-manager PATCH] virtinst: clearer error message when disks upper limits reached

[Giuseppe Scrivano]

Chen Hanxiao <chen_han_xiao at 126.com> writes:

> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>
> We set upper limits for virtio, hd ... disks in virtinst.
> So we should let users know this.
>
> Improve error message suggested by:
> https://bugzilla.redhat.com/show_bug.cgi?id=822331
>
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  virtinst/devicedisk.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
> index 469d968..1a431e5 100644
> --- a/virtinst/devicedisk.py
> +++ b/virtinst/devicedisk.py
> @@ -879,6 +879,6 @@ class VirtualDisk(VirtualDevice):
>          if ret:
>              self.target = ret
>              return ret
> -        raise ValueError(_("No more space for disks of type '%s'" % prefix))
> +        raise ValueError(_("Only %s %s disks supported in virt-manager" % (maxnode, prefix)))

ACK if you remove " in virt-manager" or even better if you keep it like:

"Only %s disks of type %s are supported"

Giuseppe