[virt-tools-list] virt-what : added docker check

[Charles Nguyen]

Thanks much, first time submitting so didn't know. The README file didn't
say anything about bugzilla and I had neglected the man page since.

Great tool though! Thanks all.

---
Please excuse autocorrect typos, sent from a phone.
On Jun 23, 2014 1:53 PM, "Richard W.M. Jones" <rjones at redhat.com> wrote:

> On Mon, Jun 23, 2014 at 12:22:56PM -0600, Eric Blake wrote:
> > On 06/21/2014 10:49 PM, Charles Nguyen wrote:
> > > I noticed that this checks and reports that Docker containers are lxc
> > > containers, but sometimes it is nice to know that you are in a Docker
> > > environment. As such, I added in a test for Docker and it returns as:
> > >
> > > bash-4.1# PATH=.:$PATH virt-what
> > > lxc
> > > docker
> > >
> > > I forked a copy and it's been tested off of a base CentOS and Ubuntu
> > > container that most packages are made from. I've also included the
> tests as
> > > well and hope that I made it correct otherwise.
> > >
> > > https://github.com/chuckleb/virt-what
> >
> > Expecting us to chase down a random URL to find the patch ourselves is
> > not as nice as including the patch directly inline as part of your
> > email.  Also, per 'man virt-what', have you created a bugzilla for this
> > patch, and cc'd Rich to make sure he sees it?
>
> Charles:
> Don't worry about the Bugzilla.
>
> I have pushed the two commits upstream.
>
> Thanks, Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-builder quickly builds VMs from scratch
> http://libguestfs.org/virt-builder.1.html
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140623/cca1b531/attachment.htm>