[virt-tools-list] [virt-manager PATCH] test: Fix tests with latest libvirt

Cole Robinson crobinso at redhat.com
Thu Sep 11 20:15:15 UTC 2014


On 09/10/2014 09:57 PM, Chen Hanxiao wrote:
> libvirt commit
> 68bf13dbef8342eaee0bf57c73cebb60b7de11e8
> conf: Extend <loader/> and introduce <nvram/>
> 

Unfortunately this then breaks the test suite with anything except latest git
master.

Can you add a new check in support.py, like SUPPORT_CONN_LOADER_ROM, dependent
on libvirt 1.2.9 or later. Then skip the affected unittests if that support
check isn't valid.

clitest.py already has infrastructure for this, grep for uses of
compare_check. The other test cases you may have to open code it.

Thanks,
Cole




More information about the virt-tools-list mailing list