[virt-tools-list] [virt-manager PATCH] test: Fix tests with latest libvirt

Chen, Hanxiao chenhanxiao at cn.fujitsu.com
Fri Sep 12 03:27:01 UTC 2014



> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Friday, September 12, 2014 4:15 AM
> To: Chen, Hanxiao/陈 晗霄; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH] test: Fix tests with latest
> libvirt
> 
> On 09/10/2014 09:57 PM, Chen Hanxiao wrote:
> > libvirt commit
> > 68bf13dbef8342eaee0bf57c73cebb60b7de11e8
> > conf: Extend <loader/> and introduce <nvram/>
> >
> 
> Unfortunately this then breaks the test suite with anything except latest git
> master.
> 
> Can you add a new check in support.py, like SUPPORT_CONN_LOADER_ROM, dependent
> on libvirt 1.2.9 or later. Then skip the affected unittests if that support
> check isn't valid.
> 
> clitest.py already has infrastructure for this, grep for uses of
> compare_check. The other test cases you may have to open code it.
> 
Thanks for the hint.

- Chen





More information about the virt-tools-list mailing list