[virt-tools-list] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

Cole Robinson crobinso at redhat.com
Sat Sep 20 00:37:07 UTC 2014

On 09/17/2014 06:55 PM, Cole Robinson wrote:
> We expose a simple combobox with two entries: BIOS, and UEFI. The
> UEFI option is only selectable if 1) libvirt supports the necessary
> domcapabilities bits, 2) it detects that qemu supports the necessary
> command line options, and 3) libvirt detects a UEFI binary on the
> host that maps to a known template via qemu.conf
> If those conditions aren't met, we disable the UEFI option, and show
> a small warning icon with an explanatory tooltip.
> The option can only be changed via New VM->Customize Before Install.
> For existing x86 VMs, it's a readonly label.

I've pushed this now, with follow up patches to handle a couple points we

- Remove the nvram deletion from delete.py, since it won't work in the
non-root case, and all uses of nvram should also be with a libvirt + driver
that provides UNDEFINE_NVRAM

- Before using UNDEFINE_NVRAM, match the same condition that libvirt uses:
loader_ro is True and loader_type == "pflash" and bool(nvram)


More information about the virt-tools-list mailing list