[virt-tools-list] [PATCH virt-viewer 1/2] app: Use debug to inform about smartcard shortcuts state

Christophe Fergeau cfergeau at redhat.com
Mon May 30 09:35:58 UTC 2016


For what it's worth, smartcard shortcuts are not meant to be used in
normal setups, I guess that's why there was a warning when enabling them
(?). Not saying I object to the patch though ;) 

Christophe

On Mon, May 30, 2016 at 11:25:34AM +0200, Pavel Grunt wrote:
> Related: rhbz#1339572
> ---
>  src/virt-viewer-app.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 6573961..d449f72 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -1762,7 +1762,7 @@ virt_viewer_update_smartcard_accels(VirtViewerApp *self)
>          sw_smartcard = FALSE;
>      }
>      if (sw_smartcard) {
> -        g_warning("enabling smartcard shortcuts");
> +        g_debug("enabling smartcard shortcuts");
>          gtk_accel_map_change_entry("<virt-viewer>/file/smartcard-insert",
>                                     priv->insert_smartcard_accel_key,
>                                     priv->insert_smartcard_accel_mods,
> @@ -1772,7 +1772,7 @@ virt_viewer_update_smartcard_accels(VirtViewerApp *self)
>                                     priv->remove_smartcard_accel_mods,
>                                     TRUE);
>      } else {
> -        g_warning("disabling smartcard shortcuts");
> +        g_debug("disabling smartcard shortcuts");
>          gtk_accel_map_change_entry("<virt-viewer>/file/smartcard-insert", 0, 0, TRUE);
>          gtk_accel_map_change_entry("<virt-viewer>/file/smartcard-remove", 0, 0, TRUE);
>      }
> -- 
> 2.8.3
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160530/d24e45ac/attachment.sig>


More information about the virt-tools-list mailing list