[zanata/zanata-platform] 2065ab: feat(ZNTA-2318): Editor Review / Reject Translatio...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-platform
  Commit: 2065abe4644519b3d1cbd6c2132fc04add2b1a9d
      https://github.com/zanata/zanata-platform/commit/2065abe4644519b3d1cbd6c2132fc04add2b1a9d
  Author: Earl Floden <efloden at redhat.com>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    A server/services/src/main/java/org/zanata/rest/editor/dto/ReviewData.java
    A server/services/src/main/java/org/zanata/rest/editor/service/TranslationReviewService.java
    A server/services/src/main/java/org/zanata/rest/editor/service/resource/TranslationReviewResource.java
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    A server/services/src/test/java/org/zanata/rest/editor/dto/ReviewDataTest.java
    A server/services/src/test/java/org/zanata/rest/editor/service/TranslationReviewServiceTest.java
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    A server/zanata-frontend/src/app/editor/actions/review-trans-actions.js
    A server/zanata-frontend/src/app/editor/actions/review-trans-actions.test.js
    M server/zanata-frontend/src/app/editor/api/index.js
    M server/zanata-frontend/src/app/editor/app.css
    M server/zanata-frontend/src/app/editor/components/Dropdown/index.css
    R server/zanata-frontend/src/app/editor/components/RejectTranslationModal/index.css
    M server/zanata-frontend/src/app/editor/components/TransUnit/index.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/containers/MainContent.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/CriteriaDropdown.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/CriteriaDropdown.test.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/PriorityDropdown.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/PriorityDropdown.test.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/RejectTranslationModal.story.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.css
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.js
    M server/zanata-frontend/src/app/editor/containers/Root/index.js
    M server/zanata-frontend/src/app/editor/reducers/index.js
    A server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.test.js
    A server/zanata-frontend/src/app/editor/utils/reject-trans-util.js
    M server/zanata-frontend/src/app/editor/utils/status-util.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.test.js
    M server/zanata-frontend/src/app/reducers/common-reducer.js
    M server/zanata-frontend/src/app/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/reducers/languages-reducer.js
    M server/zanata-frontend/src/app/reducers/profile-reducer.js

  Log Message:
  -----------
  feat(ZNTA-2318): Editor Review / Reject Translation (#688)

* refactor(ZNTA-2318): update RejectTranslationModal component to comply with linter

* refactor(ZNTA-2318): Make RejectTranslationModal a container, extract PriorityDropdown as component

* refactor(ZNTA-2318): extract CriteriaDropdown component from RejectTranslationModal

* feat(ZNTA-2318): use dynamic list for criteria select dropdown

* feat(ZNTA-2318): set up frontend rest API for posting new review

* feat(ZNTA-2318): implement backend rest interface for translation review submission

* feat(ZNTA-2318): Set up fetching list of review criteria

* feat(ZNTA-2318): complete fetching criterialist from API, implement priority change dropdown

* fix(ZNTA-2318): allow storybook to run, pass tests

* feat(ZNTA-2318): implement onCriteriaChange function for criteria dropdown selection

* feat(ZNTA-2318): pass through criteria and comment to review translation actions for posting

* feat(ZNTA-2318): move Review modal to TransUnit component, display reject translation option

* feat(ZNTA-2318): complete review modal integration

* feat(ZNTA-2318): update key shortcuts for approve/reject, reflect in UI

* test(ZNTA-2318): actions and reducer

* refactor(ZNTA-2318): introduce utils, comments, stylefixes, renaming, move fetchAllCriteria

* test(ZNTA-2318): CriteriaDropdown and PriorityDropdown

* refactor(ZNTA-2318): render RejectTranslation modal once from MainContent

* fix(ZNTA-2318): import statements reflect typescript branch changes

* refactor(ZNTA-2318): change notification null to undefined, use utils const for rejected status

* fix(ZNTA-2318): check if phrase detail is loaded

* add unit test for dto and service

* fix(ZNTA-2318): reviewdata assertion

* fix(ZNTA-2318): reviewdata assertion

* fix(ZNTA-2318): dispatch save rejected status only after successful comment

* style(ZNTA-2318): fix 'needs work' option wraping in dropdown

* test(ZNTA-2318): update tests, dropdown chevron float right

* style(ZNTA-2318): also prevent 'needs work' word wrapping in keyselect mode

* fix(ZNTA-2318): rejecting translation by keypress, MainContent now stateless

* test(ZNTA-2318): update reducer test

* fix(ZNTA-2318): enforce max len on comment field 500 chars

* fix(ZNTA-2318): focus the save options dropdown to ensure key presses register

* fix(ZNTA-2318): also constrain comment max len on server

* feat(ZNTA-2318): display remaining char count in text-area

* feat(ZNTA-2318): Key commands accept capital T,A,R,N keys (translate aprrove reject needswork)

* refactor(ZNTA-2318): use const textLimit, update textarea style

* fix(ZNTA-2318): set criteriaId to id rather than criteria obj

* feat(ZNTA-2318): hide criteria/priority options if none exists. allow submitting reviews if either no criteria or no comment'

* test(ZNTA-2318): remove review criteria null test, as we now allow null criteria

* fix(ZNTA-2318): check for empty criteria array

* refactor(ZNTA-2318) use lodash isEmpty to check reviewComment/criteriaList

* refactor(ZNTA-2318): improve criteria null check readability: