[zanata/zanata-platform] 2065ab: feat(ZNTA-2318): Editor Review / Reject Translatio...

GitHub noreply at github.com
Fri Feb 16 01:03:32 UTC 2018 

  Branch: refs/heads/efloden/frontend-localization/ZNTA-2113
  Home:   https://github.com/zanata/zanata-platform
  Commit: 2065abe4644519b3d1cbd6c2132fc04add2b1a9d
      https://github.com/zanata/zanata-platform/commit/2065abe4644519b3d1cbd6c2132fc04add2b1a9d
  Author: Earl Floden <efloden at redhat.com>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    A server/services/src/main/java/org/zanata/rest/editor/dto/ReviewData.java
    A server/services/src/main/java/org/zanata/rest/editor/service/TranslationReviewService.java
    A server/services/src/main/java/org/zanata/rest/editor/service/resource/TranslationReviewResource.java
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    A server/services/src/test/java/org/zanata/rest/editor/dto/ReviewDataTest.java
    A server/services/src/test/java/org/zanata/rest/editor/service/TranslationReviewServiceTest.java
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    A server/zanata-frontend/src/app/editor/actions/review-trans-actions.js
    A server/zanata-frontend/src/app/editor/actions/review-trans-actions.test.js
    M server/zanata-frontend/src/app/editor/api/index.js
    M server/zanata-frontend/src/app/editor/app.css
    M server/zanata-frontend/src/app/editor/components/Dropdown/index.css
    R server/zanata-frontend/src/app/editor/components/RejectTranslationModal/index.css
    M server/zanata-frontend/src/app/editor/components/TransUnit/index.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/containers/MainContent.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/CriteriaDropdown.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/CriteriaDropdown.test.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/PriorityDropdown.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/PriorityDropdown.test.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/RejectTranslationModal.story.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.css
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.js
    M server/zanata-frontend/src/app/editor/containers/Root/index.js
    M server/zanata-frontend/src/app/editor/reducers/index.js
    A server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.test.js
    A server/zanata-frontend/src/app/editor/utils/reject-trans-util.js
    M server/zanata-frontend/src/app/editor/utils/status-util.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.test.js
    M server/zanata-frontend/src/app/reducers/common-reducer.js
    M server/zanata-frontend/src/app/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/reducers/languages-reducer.js
    M server/zanata-frontend/src/app/reducers/profile-reducer.js

  Log Message:
  -----------
  feat(ZNTA-2318): Editor Review / Reject Translation (#688)

* refactor(ZNTA-2318): update RejectTranslationModal component to comply with linter

* refactor(ZNTA-2318): Make RejectTranslationModal a container, extract PriorityDropdown as component

* refactor(ZNTA-2318): extract CriteriaDropdown component from RejectTranslationModal

* feat(ZNTA-2318): use dynamic list for criteria select dropdown

* feat(ZNTA-2318): set up frontend rest API for posting new review

* feat(ZNTA-2318): implement backend rest interface for translation review submission

* feat(ZNTA-2318): Set up fetching list of review criteria

* feat(ZNTA-2318): complete fetching criterialist from API, implement priority change dropdown

* fix(ZNTA-2318): allow storybook to run, pass tests

* feat(ZNTA-2318): implement onCriteriaChange function for criteria dropdown selection

* feat(ZNTA-2318): pass through criteria and comment to review translation actions for posting

* feat(ZNTA-2318): move Review modal to TransUnit component, display reject translation option

* feat(ZNTA-2318): complete review modal integration

* feat(ZNTA-2318): update key shortcuts for approve/reject, reflect in UI

* test(ZNTA-2318): actions and reducer

* refactor(ZNTA-2318): introduce utils, comments, stylefixes, renaming, move fetchAllCriteria

* test(ZNTA-2318): CriteriaDropdown and PriorityDropdown

* refactor(ZNTA-2318): render RejectTranslation modal once from MainContent

* fix(ZNTA-2318): import statements reflect typescript branch changes

* refactor(ZNTA-2318): change notification null to undefined, use utils const for rejected status

* fix(ZNTA-2318): check if phrase detail is loaded

* add unit test for dto and service

* fix(ZNTA-2318): reviewdata assertion

* fix(ZNTA-2318): reviewdata assertion

* fix(ZNTA-2318): dispatch save rejected status only after successful comment

* style(ZNTA-2318): fix 'needs work' option wraping in dropdown

* test(ZNTA-2318): update tests, dropdown chevron float right

* style(ZNTA-2318): also prevent 'needs work' word wrapping in keyselect mode

* fix(ZNTA-2318): rejecting translation by keypress, MainContent now stateless

* test(ZNTA-2318): update reducer test

* fix(ZNTA-2318): enforce max len on comment field 500 chars

* fix(ZNTA-2318): focus the save options dropdown to ensure key presses register

* fix(ZNTA-2318): also constrain comment max len on server

* feat(ZNTA-2318): display remaining char count in text-area

* feat(ZNTA-2318): Key commands accept capital T,A,R,N keys (translate aprrove reject needswork)

* refactor(ZNTA-2318): use const textLimit, update textarea style

* fix(ZNTA-2318): set criteriaId to id rather than criteria obj

* feat(ZNTA-2318): hide criteria/priority options if none exists. allow submitting reviews if either no criteria or no comment'

* test(ZNTA-2318): remove review criteria null test, as we now allow null criteria

* fix(ZNTA-2318): check for empty criteria array

* refactor(ZNTA-2318) use lodash isEmpty to check reviewComment/criteriaList

* refactor(ZNTA-2318): improve criteria null check readability:


  Commit: 5a9ec065bfe21871d67b921d1a254f4a4c0ff4d1
      https://github.com/zanata/zanata-platform/commit/5a9ec065bfe21871d67b921d1a254f4a4c0ff4d1
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-02-16 (Fri, 16 Feb 2018)

  Changed paths:
    M server/zanata-frontend/src/.storybook-editor/storyshots-editor.test.js
    M server/zanata-frontend/src/.storybook-editor/storyshots-util.js
    M server/zanata-frontend/src/.storybook-frontend/storyshots-frontend.test.js
    M server/zanata-frontend/src/.yarnrc
    M server/zanata-frontend/src/app/actions/common-actions.js
    M server/zanata-frontend/src/app/actions/explore-actions.js
    M server/zanata-frontend/src/app/actions/glossary-actions.js
    M server/zanata-frontend/src/app/actions/languages-actions.js
    M server/zanata-frontend/src/app/actions/profile-actions.js
    M server/zanata-frontend/src/app/actions/tmx-actions.js
    M server/zanata-frontend/src/app/actions/version-actions.js
    M server/zanata-frontend/src/app/actions/version-actions.test.js
    M server/zanata-frontend/src/app/components/Breadcrumbs/Breadcrumbs.story.js
    M server/zanata-frontend/src/app/components/Button/Button.story.js
    M server/zanata-frontend/src/app/components/DraggableVersionPanels/DraggableVersionPanels.test.js
    M server/zanata-frontend/src/app/components/Dropdown/Dropdown.story.js
    M server/zanata-frontend/src/app/components/EditableText/EditableText.story.js
    M server/zanata-frontend/src/app/components/EditableText/index.js
    M server/zanata-frontend/src/app/components/Form/Form.story.js
    M server/zanata-frontend/src/app/components/Icon/Icon.story.js
    M server/zanata-frontend/src/app/components/Icons/index.jsx.src
    M server/zanata-frontend/src/app/components/Link/Link.story.js
    M server/zanata-frontend/src/app/components/Link/index.js
    M server/zanata-frontend/src/app/components/Modal/Modal.story.js
    M server/zanata-frontend/src/app/components/Modal/ModalBody.jsx
    M server/zanata-frontend/src/app/components/Modal/ModalHeader.jsx
    M server/zanata-frontend/src/app/components/Modal/ModalTitle.jsx
    M server/zanata-frontend/src/app/components/Modal/index.jsx
    M server/zanata-frontend/src/app/components/Nav/NavIcon.jsx
    M server/zanata-frontend/src/app/components/Nav/NavItem.jsx
    M server/zanata-frontend/src/app/components/Nav/index.jsx
    M server/zanata-frontend/src/app/components/Notification/component.js
    M server/zanata-frontend/src/app/components/Notification/index.js
    M server/zanata-frontend/src/app/components/Pagination/Pagination.story.js
    M server/zanata-frontend/src/app/components/Panel/Panel.story.js
    M server/zanata-frontend/src/app/components/RejectionsForm/RejectionsForm.story.js
    M server/zanata-frontend/src/app/components/RejectionsForm/index.js
    M server/zanata-frontend/src/app/components/SelectableDropdown/index.js
    M server/zanata-frontend/src/app/components/TMX/TMXExportModal.js
    M server/zanata-frontend/src/app/components/Table/Table.story.js
    M server/zanata-frontend/src/app/components/Tabs/Tabs.story.js
    M server/zanata-frontend/src/app/components/TextInput/TextInput.story.js
    M server/zanata-frontend/src/app/components/TextInput/index.js
    M server/zanata-frontend/src/app/components/TriCheckbox/TriCheckbox.story.js
    M server/zanata-frontend/src/app/components/TriCheckbox/TriCheckbox.test.js
    M server/zanata-frontend/src/app/components/TriCheckbox/TriCheckboxGroup.js
    M server/zanata-frontend/src/app/components/VersionTMMergeModal/VersionTMMergeModal.story.js
    M server/zanata-frontend/src/app/components/foundation.story.js
    M server/zanata-frontend/src/app/config.js
    M server/zanata-frontend/src/app/containers/Admin/Review.js
    M server/zanata-frontend/src/app/containers/Admin/index.js
    M server/zanata-frontend/src/app/containers/App.js
    M server/zanata-frontend/src/app/containers/Explore/GroupTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/LanguageTeamTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/ProjectTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/TeaserList.jsx
    M server/zanata-frontend/src/app/containers/Explore/TeaserListHeader.jsx
    M server/zanata-frontend/src/app/containers/Explore/UserTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/index.js
    M server/zanata-frontend/src/app/containers/Glossary/DeleteAllEntriesModal.jsx
    M server/zanata-frontend/src/app/containers/Glossary/DeleteEntryModal.jsx
    M server/zanata-frontend/src/app/containers/Glossary/Entry.js
    M server/zanata-frontend/src/app/containers/Glossary/EntryModal.js
    M server/zanata-frontend/src/app/containers/Glossary/ExportModal.js
    M server/zanata-frontend/src/app/containers/Glossary/Header.jsx
    M server/zanata-frontend/src/app/containers/Glossary/ImportModal.js
    M server/zanata-frontend/src/app/containers/Glossary/NewEntryModal.js
    M server/zanata-frontend/src/app/containers/Glossary/ViewHeader.js
    M server/zanata-frontend/src/app/containers/Glossary/index.js
    M server/zanata-frontend/src/app/containers/Languages/Entry.js
    M server/zanata-frontend/src/app/containers/Languages/NewLanguageModal.js
    M server/zanata-frontend/src/app/containers/Languages/index.js
    M server/zanata-frontend/src/app/containers/Project/index.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/AboutPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/DocumentsPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/GroupsPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/LanguagesPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/PeoplePage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/ProjectVersionPanels.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeModal.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeOptionsCommon.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeProjectSources.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeProjectTMOptions.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/index.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/project-version-displays.js
    M server/zanata-frontend/src/app/containers/UserProfile/CalendarMonthMatrix.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/CalendarPeriodHeading.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/CategoryMatrixTable.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/ContentStateFilter.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/ContributionChart.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/DayMatrix.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/FilterableMatrixTable.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/RecentContributions.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/index.jsx
    M server/zanata-frontend/src/app/editor/actions/controls-header-actions.js
    M server/zanata-frontend/src/app/editor/actions/glossary-actions.js
    M server/zanata-frontend/src/app/editor/actions/header-actions.js
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/app/editor/actions/review-trans-actions.js
    M server/zanata-frontend/src/app/editor/actions/settings-actions.js
    M server/zanata-frontend/src/app/editor/actions/settings-actions.test.js
    M server/zanata-frontend/src/app/editor/actions/suggestions-actions.js
    M server/zanata-frontend/src/app/editor/api/suggestions.js
    M server/zanata-frontend/src/app/editor/components/ActivityFeedItem/index.js
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/ActivitySelectList.story.js
    M server/zanata-frontend/src/app/editor/components/Button/Button.story.js
    M server/zanata-frontend/src/app/editor/components/Button/Button.test.js
    M server/zanata-frontend/src/app/editor/components/CommentBox/CommentBox.story.js
    M server/zanata-frontend/src/app/editor/components/ConcurrentModal/Concurrent.story.js
    M server/zanata-frontend/src/app/editor/components/ConcurrentModal/index.js
    M server/zanata-frontend/src/app/editor/components/DateAndTimeDisplay/DateAndTimeDisplay.story.js
    M server/zanata-frontend/src/app/editor/components/DateAndTimeDisplay/index.js
    M server/zanata-frontend/src/app/editor/components/Dropdown/Dropdown.test.js
    M server/zanata-frontend/src/app/editor/components/Dropdown/index.js
    M server/zanata-frontend/src/app/editor/components/EditorSearchInput/EditorSearchInput.story.js
    M server/zanata-frontend/src/app/editor/components/EditorSearchInput/EditorSearchInput.test.js
    M server/zanata-frontend/src/app/editor/components/EditorSearchInput/index.js
    M server/zanata-frontend/src/app/editor/components/GlossarySearchInput/index.js
    M server/zanata-frontend/src/app/editor/components/GlossaryTerm/GlossaryTerm.story.js
    M server/zanata-frontend/src/app/editor/components/GlossaryTermModal/component.js
    M server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.js
    M server/zanata-frontend/src/app/editor/components/IconButton/IconButton.test.js
    M server/zanata-frontend/src/app/editor/components/IconButtonToggle/IconButtonToggle.test.js
    M server/zanata-frontend/src/app/editor/components/KeyCombinations.js
    M server/zanata-frontend/src/app/editor/components/LanguageSelectList/LanguageSelectList.story.js
    M server/zanata-frontend/src/app/editor/components/NoSuggestionsPanel/NoSuggestionsPanel.test.js
    M server/zanata-frontend/src/app/editor/components/NoSuggestionsPanel/index.js
    M server/zanata-frontend/src/app/editor/components/Pager/Pager.test.js
    M server/zanata-frontend/src/app/editor/components/Pager/index.js
    M server/zanata-frontend/src/app/editor/components/PhraseStatusFilter/PhraseStatusFilter.test.js
    M server/zanata-frontend/src/app/editor/components/ProgressBar/ProgressBar.story.js
    M server/zanata-frontend/src/app/editor/components/RejectTranslationModal/RejectTranslationModal.story.js
    M server/zanata-frontend/src/app/editor/components/RejectTranslationModal/index.js
    M server/zanata-frontend/src/app/editor/components/SelectButton/SelectButton.story.js
    M server/zanata-frontend/src/app/editor/components/SelectButton/index.js
    M server/zanata-frontend/src/app/editor/components/SelectButtonList/SelectButtonList.story.js
    M server/zanata-frontend/src/app/editor/components/SelectButtonList/index.js
    M server/zanata-frontend/src/app/editor/components/SettingOption/SettingOption.story.js
    M server/zanata-frontend/src/app/editor/components/SettingsOptions/SettingsOptions.story.js
    M server/zanata-frontend/src/app/editor/components/SettingsOptions/index.js
    M server/zanata-frontend/src/app/editor/components/SuggestionContents/SuggestionContents.test.js
    M server/zanata-frontend/src/app/editor/components/SuggestionContents/index.js
    M server/zanata-frontend/src/app/editor/components/SuggestionSearchInput/index.js
    M server/zanata-frontend/src/app/editor/components/TextDiff/TextDiff.story.js
    M server/zanata-frontend/src/app/editor/components/TextDiff/TextDiff.test.js
    M server/zanata-frontend/src/app/editor/components/TextDiff/index.js
    M server/zanata-frontend/src/app/editor/components/ToggleSwitch/ToggleSwitch.test.js
    M server/zanata-frontend/src/app/editor/components/TransUnit/index.js
    M server/zanata-frontend/src/app/editor/components/TransUnitSourcePanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/UiLanguageDropdown/UiLanguageDropdown.test.js
    M server/zanata-frontend/src/app/editor/containers/ActivityTab.js
    M server/zanata-frontend/src/app/editor/containers/ControlsHeader.js
    M server/zanata-frontend/src/app/editor/containers/EditorHeader/index.js
    M server/zanata-frontend/src/app/editor/containers/GlossaryTab.js
    M server/zanata-frontend/src/app/editor/containers/KeyShortcutDispatcher.js
    M server/zanata-frontend/src/app/editor/containers/MainContent.js
    M server/zanata-frontend/src/app/editor/containers/NavHeader.js
    M server/zanata-frontend/src/app/editor/containers/ParamPropDispatcher.js
    M server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/RejectTranslationModal.story.js
    M server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.js
    M server/zanata-frontend/src/app/editor/containers/Root/index.js
    M server/zanata-frontend/src/app/editor/containers/SettingsPanel.js
    M server/zanata-frontend/src/app/editor/containers/Sidebar/index.js
    M server/zanata-frontend/src/app/editor/containers/SidebarContent.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionDetailsModal/ImportedTMDetailPanel.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionDetailsModal/LocalProjectDetailPanel.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionDetailsModal/index.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionsPanel.js
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    M server/zanata-frontend/src/app/editor/containers/ZanataLogoLoader.js
    M server/zanata-frontend/src/app/editor/index.js
    M server/zanata-frontend/src/app/editor/messages/index.js
    M server/zanata-frontend/src/app/editor/middlewares/call-api.js
    M server/zanata-frontend/src/app/editor/middlewares/index.js
    M server/zanata-frontend/src/app/editor/middlewares/new-context-fetch.js
    M server/zanata-frontend/src/app/editor/middlewares/title-update.js
    M server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/header-data-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-filter-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.test.js
    M server/zanata-frontend/src/app/editor/utils/RoutingHelpers.js
    M server/zanata-frontend/src/app/editor/utils/Util.js
    M server/zanata-frontend/src/app/editor/watchers/page-number.js
    M server/zanata-frontend/src/app/editor/watchers/phrase-detail.js
    M server/zanata-frontend/src/app/editor/watchers/phrase-list.js
    M server/zanata-frontend/src/app/history.js
    M server/zanata-frontend/src/app/index.js
    M server/zanata-frontend/src/app/jsf/JsfRoot.js
    M server/zanata-frontend/src/app/jsf/index.js
    M server/zanata-frontend/src/app/legacy.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.test.js
    M server/zanata-frontend/src/app/reducers/common-reducer.js
    M server/zanata-frontend/src/app/reducers/explore-reducer.js
    M server/zanata-frontend/src/app/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/reducers/index.js
    M server/zanata-frontend/src/app/reducers/languages-reducer.js
    M server/zanata-frontend/src/app/reducers/profile-reducer.js
    M server/zanata-frontend/src/app/reducers/tmx-reducer.js
    M server/zanata-frontend/src/app/reducers/version-reducer.js
    M server/zanata-frontend/src/app/reducers/version-reducer.test.js
    M server/zanata-frontend/src/app/utils/GlossaryHelper.test.js
    M server/zanata-frontend/src/app/utils/RoutingHelpers.js
    M server/zanata-frontend/src/app/utils/UrlHelper.js
    M server/zanata-frontend/src/app/utils/callWithSameArgs.js
    R server/zanata-frontend/src/build/messages/app/editor/components/ActivityFeedItem/index.json
    M server/zanata-frontend/src/package.json
    M server/zanata-frontend/src/scripts/codemods/story.template.js
    M server/zanata-frontend/src/tsconfig.json
    M server/zanata-frontend/src/webpack.config.js
    M server/zanata-frontend/src/yarn.lock

  Log Message:
  -----------
  Type check JS by default (#709)

* Let TypeScript check JS files by default
    Disable checking by adding this at the top of a JS file:
    // @ts-nocheck
* Rename unused vars
* Remove ts-check comments
* Let TS parse storybook, webpack config
* Use action from @storybook/addon-actions
* Ensure yarn install, not npm
* Freeze yarn.lock only for install, not add/remove


  Commit: 899308821a4fdd5eff2c62ed9bf62f1dae49b7d8
      https://github.com/zanata/zanata-platform/commit/899308821a4fdd5eff2c62ed9bf62f1dae49b7d8
  Author: efloden <efloden at redhat.com>
  Date:   2018-02-16 (Fri, 16 Feb 2018)

  Changed paths:
    A server/services/src/main/java/org/zanata/rest/editor/dto/ReviewData.java
    A server/services/src/main/java/org/zanata/rest/editor/service/TranslationReviewService.java
    A server/services/src/main/java/org/zanata/rest/editor/service/resource/TranslationReviewResource.java
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    A server/services/src/test/java/org/zanata/rest/editor/dto/ReviewDataTest.java
    A server/services/src/test/java/org/zanata/rest/editor/service/TranslationReviewServiceTest.java
    M server/zanata-frontend/src/.storybook-editor/storyshots-editor.test.js
    M server/zanata-frontend/src/.storybook-editor/storyshots-util.js
    M server/zanata-frontend/src/.storybook-frontend/storyshots-frontend.test.js
    M server/zanata-frontend/src/.yarnrc
    M server/zanata-frontend/src/app/actions/common-actions.js
    M server/zanata-frontend/src/app/actions/explore-actions.js
    M server/zanata-frontend/src/app/actions/glossary-actions.js
    M server/zanata-frontend/src/app/actions/languages-actions.js
    M server/zanata-frontend/src/app/actions/profile-actions.js
    M server/zanata-frontend/src/app/actions/tmx-actions.js
    M server/zanata-frontend/src/app/actions/version-actions.js
    M server/zanata-frontend/src/app/actions/version-actions.test.js
    M server/zanata-frontend/src/app/components/Breadcrumbs/Breadcrumbs.story.js
    M server/zanata-frontend/src/app/components/Button/Button.story.js
    M server/zanata-frontend/src/app/components/DraggableVersionPanels/DraggableVersionPanels.test.js
    M server/zanata-frontend/src/app/components/Dropdown/Dropdown.story.js
    M server/zanata-frontend/src/app/components/EditableText/EditableText.story.js
    M server/zanata-frontend/src/app/components/EditableText/index.js
    M server/zanata-frontend/src/app/components/Form/Form.story.js
    M server/zanata-frontend/src/app/components/Icon/Icon.story.js
    M server/zanata-frontend/src/app/components/Icons/index.jsx.src
    M server/zanata-frontend/src/app/components/Link/Link.story.js
    M server/zanata-frontend/src/app/components/Link/index.js
    M server/zanata-frontend/src/app/components/Modal/Modal.story.js
    M server/zanata-frontend/src/app/components/Modal/ModalBody.jsx
    M server/zanata-frontend/src/app/components/Modal/ModalHeader.jsx
    M server/zanata-frontend/src/app/components/Modal/ModalTitle.jsx
    M server/zanata-frontend/src/app/components/Modal/index.jsx
    M server/zanata-frontend/src/app/components/Nav/NavIcon.jsx
    M server/zanata-frontend/src/app/components/Nav/NavItem.jsx
    M server/zanata-frontend/src/app/components/Nav/index.jsx
    M server/zanata-frontend/src/app/components/Notification/component.js
    M server/zanata-frontend/src/app/components/Notification/index.js
    M server/zanata-frontend/src/app/components/Pagination/Pagination.story.js
    M server/zanata-frontend/src/app/components/Panel/Panel.story.js
    M server/zanata-frontend/src/app/components/RejectionsForm/RejectionsForm.story.js
    M server/zanata-frontend/src/app/components/RejectionsForm/index.js
    M server/zanata-frontend/src/app/components/SelectableDropdown/index.js
    M server/zanata-frontend/src/app/components/TMX/TMXExportModal.js
    M server/zanata-frontend/src/app/components/Table/Table.story.js
    M server/zanata-frontend/src/app/components/Tabs/Tabs.story.js
    M server/zanata-frontend/src/app/components/TextInput/TextInput.story.js
    M server/zanata-frontend/src/app/components/TextInput/index.js
    M server/zanata-frontend/src/app/components/TriCheckbox/TriCheckbox.story.js
    M server/zanata-frontend/src/app/components/TriCheckbox/TriCheckbox.test.js
    M server/zanata-frontend/src/app/components/TriCheckbox/TriCheckboxGroup.js
    M server/zanata-frontend/src/app/components/VersionTMMergeModal/VersionTMMergeModal.story.js
    M server/zanata-frontend/src/app/components/foundation.story.js
    M server/zanata-frontend/src/app/config.js
    M server/zanata-frontend/src/app/containers/Admin/Review.js
    M server/zanata-frontend/src/app/containers/Admin/index.js
    M server/zanata-frontend/src/app/containers/App.js
    M server/zanata-frontend/src/app/containers/Explore/GroupTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/LanguageTeamTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/ProjectTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/TeaserList.jsx
    M server/zanata-frontend/src/app/containers/Explore/TeaserListHeader.jsx
    M server/zanata-frontend/src/app/containers/Explore/UserTeaser.jsx
    M server/zanata-frontend/src/app/containers/Explore/index.js
    M server/zanata-frontend/src/app/containers/Glossary/DeleteAllEntriesModal.jsx
    M server/zanata-frontend/src/app/containers/Glossary/DeleteEntryModal.jsx
    M server/zanata-frontend/src/app/containers/Glossary/Entry.js
    M server/zanata-frontend/src/app/containers/Glossary/EntryModal.js
    M server/zanata-frontend/src/app/containers/Glossary/ExportModal.js
    M server/zanata-frontend/src/app/containers/Glossary/Header.jsx
    M server/zanata-frontend/src/app/containers/Glossary/ImportModal.js
    M server/zanata-frontend/src/app/containers/Glossary/NewEntryModal.js
    M server/zanata-frontend/src/app/containers/Glossary/ViewHeader.js
    M server/zanata-frontend/src/app/containers/Glossary/index.js
    M server/zanata-frontend/src/app/containers/Languages/Entry.js
    M server/zanata-frontend/src/app/containers/Languages/NewLanguageModal.js
    M server/zanata-frontend/src/app/containers/Languages/index.js
    M server/zanata-frontend/src/app/containers/Project/index.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/AboutPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/DocumentsPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/GroupsPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/LanguagesPage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/PeoplePage.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/ProjectVersionPanels.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeModal.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeOptionsCommon.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeProjectSources.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/TMMergeProjectTMOptions.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/index.js
    M server/zanata-frontend/src/app/containers/ProjectVersion/project-version-displays.js
    M server/zanata-frontend/src/app/containers/UserProfile/CalendarMonthMatrix.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/CalendarPeriodHeading.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/CategoryMatrixTable.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/ContentStateFilter.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/ContributionChart.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/DayMatrix.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/FilterableMatrixTable.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/RecentContributions.jsx
    M server/zanata-frontend/src/app/containers/UserProfile/index.jsx
    M server/zanata-frontend/src/app/editor/actions/controls-header-actions.js
    M server/zanata-frontend/src/app/editor/actions/glossary-actions.js
    M server/zanata-frontend/src/app/editor/actions/header-actions.js
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-filter-actions.js
    A server/zanata-frontend/src/app/editor/actions/review-trans-actions.js
    A server/zanata-frontend/src/app/editor/actions/review-trans-actions.test.js
    M server/zanata-frontend/src/app/editor/actions/settings-actions.js
    M server/zanata-frontend/src/app/editor/actions/settings-actions.test.js
    M server/zanata-frontend/src/app/editor/actions/suggestions-actions.js
    M server/zanata-frontend/src/app/editor/api/index.js
    M server/zanata-frontend/src/app/editor/api/suggestions.js
    M server/zanata-frontend/src/app/editor/app.css
    M server/zanata-frontend/src/app/editor/components/ActivityFeedItem/index.js
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/ActivitySelectList.story.js
    M server/zanata-frontend/src/app/editor/components/Button/Button.story.js
    M server/zanata-frontend/src/app/editor/components/Button/Button.test.js
    M server/zanata-frontend/src/app/editor/components/CommentBox/CommentBox.story.js
    M server/zanata-frontend/src/app/editor/components/ConcurrentModal/Concurrent.story.js
    M server/zanata-frontend/src/app/editor/components/ConcurrentModal/index.js
    M server/zanata-frontend/src/app/editor/components/DateAndTimeDisplay/DateAndTimeDisplay.story.js
    M server/zanata-frontend/src/app/editor/components/DateAndTimeDisplay/index.js
    M server/zanata-frontend/src/app/editor/components/Dropdown/Dropdown.test.js
    M server/zanata-frontend/src/app/editor/components/Dropdown/index.css
    M server/zanata-frontend/src/app/editor/components/Dropdown/index.js
    M server/zanata-frontend/src/app/editor/components/EditorSearchInput/EditorSearchInput.story.js
    M server/zanata-frontend/src/app/editor/components/EditorSearchInput/EditorSearchInput.test.js
    M server/zanata-frontend/src/app/editor/components/EditorSearchInput/index.js
    M server/zanata-frontend/src/app/editor/components/GlossarySearchInput/index.js
    M server/zanata-frontend/src/app/editor/components/GlossaryTerm/GlossaryTerm.story.js
    M server/zanata-frontend/src/app/editor/components/GlossaryTermModal/component.js
    M server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.js
    M server/zanata-frontend/src/app/editor/components/IconButton/IconButton.test.js
    M server/zanata-frontend/src/app/editor/components/IconButtonToggle/IconButtonToggle.test.js
    M server/zanata-frontend/src/app/editor/components/KeyCombinations.js
    M server/zanata-frontend/src/app/editor/components/LanguageSelectList/LanguageSelectList.story.js
    M server/zanata-frontend/src/app/editor/components/NoSuggestionsPanel/NoSuggestionsPanel.test.js
    M server/zanata-frontend/src/app/editor/components/NoSuggestionsPanel/index.js
    M server/zanata-frontend/src/app/editor/components/Pager/Pager.test.js
    M server/zanata-frontend/src/app/editor/components/Pager/index.js
    M server/zanata-frontend/src/app/editor/components/PhraseStatusFilter/PhraseStatusFilter.test.js
    M server/zanata-frontend/src/app/editor/components/ProgressBar/ProgressBar.story.js
    M server/zanata-frontend/src/app/editor/components/RejectTranslationModal/RejectTranslationModal.story.js
    R server/zanata-frontend/src/app/editor/components/RejectTranslationModal/index.css
    M server/zanata-frontend/src/app/editor/components/RejectTranslationModal/index.js
    M server/zanata-frontend/src/app/editor/components/SelectButton/SelectButton.story.js
    M server/zanata-frontend/src/app/editor/components/SelectButton/index.js
    M server/zanata-frontend/src/app/editor/components/SelectButtonList/SelectButtonList.story.js
    M server/zanata-frontend/src/app/editor/components/SelectButtonList/index.js
    M server/zanata-frontend/src/app/editor/components/SettingOption/SettingOption.story.js
    M server/zanata-frontend/src/app/editor/components/SettingsOptions/SettingsOptions.story.js
    M server/zanata-frontend/src/app/editor/components/SettingsOptions/index.js
    M server/zanata-frontend/src/app/editor/components/SuggestionContents/SuggestionContents.test.js
    M server/zanata-frontend/src/app/editor/components/SuggestionContents/index.js
    M server/zanata-frontend/src/app/editor/components/SuggestionSearchInput/index.js
    M server/zanata-frontend/src/app/editor/components/TextDiff/TextDiff.story.js
    M server/zanata-frontend/src/app/editor/components/TextDiff/TextDiff.test.js
    M server/zanata-frontend/src/app/editor/components/TextDiff/index.js
    M server/zanata-frontend/src/app/editor/components/ToggleSwitch/ToggleSwitch.test.js
    M server/zanata-frontend/src/app/editor/components/TransUnit/index.js
    M server/zanata-frontend/src/app/editor/components/TransUnitSourcePanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/UiLanguageDropdown/UiLanguageDropdown.test.js
    M server/zanata-frontend/src/app/editor/containers/ActivityTab.js
    M server/zanata-frontend/src/app/editor/containers/ControlsHeader.js
    M server/zanata-frontend/src/app/editor/containers/EditorHeader/index.js
    M server/zanata-frontend/src/app/editor/containers/GlossaryTab.js
    M server/zanata-frontend/src/app/editor/containers/KeyShortcutDispatcher.js
    M server/zanata-frontend/src/app/editor/containers/MainContent.js
    M server/zanata-frontend/src/app/editor/containers/NavHeader.js
    M server/zanata-frontend/src/app/editor/containers/ParamPropDispatcher.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/CriteriaDropdown.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/CriteriaDropdown.test.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/PriorityDropdown.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/PriorityDropdown.test.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/RejectTranslationModal.story.js
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.css
    A server/zanata-frontend/src/app/editor/containers/RejectTranslationModal/index.js
    M server/zanata-frontend/src/app/editor/containers/Root/index.js
    M server/zanata-frontend/src/app/editor/containers/SettingsPanel.js
    M server/zanata-frontend/src/app/editor/containers/Sidebar/index.js
    M server/zanata-frontend/src/app/editor/containers/SidebarContent.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionDetailsModal/ImportedTMDetailPanel.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionDetailsModal/LocalProjectDetailPanel.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionDetailsModal/index.js
    M server/zanata-frontend/src/app/editor/containers/SuggestionsPanel.js
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    M server/zanata-frontend/src/app/editor/containers/ZanataLogoLoader.js
    M server/zanata-frontend/src/app/editor/index.js
    M server/zanata-frontend/src/app/editor/messages/index.js
    M server/zanata-frontend/src/app/editor/middlewares/call-api.js
    M server/zanata-frontend/src/app/editor/middlewares/index.js
    M server/zanata-frontend/src/app/editor/middlewares/new-context-fetch.js
    M server/zanata-frontend/src/app/editor/middlewares/title-update.js
    M server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/header-data-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-filter-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-reducer.test.js
    A server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.test.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.test.js
    M server/zanata-frontend/src/app/editor/utils/RoutingHelpers.js
    M server/zanata-frontend/src/app/editor/utils/Util.js
    A server/zanata-frontend/src/app/editor/utils/reject-trans-util.js
    M server/zanata-frontend/src/app/editor/utils/status-util.js
    M server/zanata-frontend/src/app/editor/watchers/page-number.js
    M server/zanata-frontend/src/app/editor/watchers/phrase-detail.js
    M server/zanata-frontend/src/app/editor/watchers/phrase-list.js
    M server/zanata-frontend/src/app/history.js
    M server/zanata-frontend/src/app/index.js
    M server/zanata-frontend/src/app/jsf/JsfRoot.js
    M server/zanata-frontend/src/app/jsf/index.js
    M server/zanata-frontend/src/app/legacy.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.test.js
    M server/zanata-frontend/src/app/reducers/common-reducer.js
    M server/zanata-frontend/src/app/reducers/explore-reducer.js
    M server/zanata-frontend/src/app/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/reducers/index.js
    M server/zanata-frontend/src/app/reducers/languages-reducer.js
    M server/zanata-frontend/src/app/reducers/profile-reducer.js
    M server/zanata-frontend/src/app/reducers/tmx-reducer.js
    M server/zanata-frontend/src/app/reducers/version-reducer.js
    M server/zanata-frontend/src/app/reducers/version-reducer.test.js
    M server/zanata-frontend/src/app/utils/GlossaryHelper.test.js
    M server/zanata-frontend/src/app/utils/RoutingHelpers.js
    M server/zanata-frontend/src/app/utils/UrlHelper.js
    M server/zanata-frontend/src/app/utils/callWithSameArgs.js
    R server/zanata-frontend/src/build/messages/app/editor/components/ActivityFeedItem/index.json
    M server/zanata-frontend/src/package.json
    M server/zanata-frontend/src/scripts/codemods/story.template.js
    M server/zanata-frontend/src/tsconfig.json
    M server/zanata-frontend/src/webpack.config.js
    M server/zanata-frontend/src/yarn.lock

  Log Message:
  -----------
  Merge branch 'master' of github.com:zanata/zanata-platform into efloden/frontend-localization/ZNTA-2113


Compare: https://github.com/zanata/zanata-platform/compare/3eabc399742a...899308821a4f

More information about the zanata-commits mailing list