[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #15 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-27 12:28:24 EDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > rpmlint reports some errors and a warning:
> > 
> > ne7ssh.ppc: E: description-line-too-long applications. You can now use the
> > NetSieben's API, instead of spending countless
> > ne7ssh.src: E: description-line-too-long applications. You can now use the
> > NetSieben's API, instead of spending countless
> Hm, I don't see this warnings. What version of rpmlint you are using?
> 
> $ rpm -q rpmlint
> rpmlint-0.90-1.fc11.noarch

I'm using the same version. But you should make yourself familiar with mock. It
ensures that you have a clean build area. If you are really really unsure about
your build you can try using koji. But before that you should use mock. I did a
built for you on koji and still get the following errors/warnings:

ne7ssh.ppc: E: description-line-too-long applications. You can now use the
NetSieben's API, instead of spending countless
ne7ssh.src: E: description-line-too-long applications. You can now use the
NetSieben's API, instead of spending countless
ne7ssh-devel.ppc: W: no-documentation
ne7ssh-doc.noarch: E: devel-dependency ne7ssh-devel
5 packages and 0 specfiles checked; 3 errors, 1 warnings.

> http://hubbitus.net.ru/rpm/Fedora11/ne7ssh/ne7ssh-1.3.1-3.fc11.src.rpm

Whenever you change something at your package then do a release bump. I have
two versions of your package (release 3):

$ md5sum ne7ssh-1.3.1-3.fc11.src.rpm*
61b1be340be8e6572101f6a0d293ac3d  ne7ssh-1.3.1-3.fc11.src.rpm
bc8156ac376386796d5ef319b582d6f1 
ne7ssh-1.3.1-3.fc11.src.rpm-BUMP_RELEASE_FORGOTTEN

$ rpmdiff ne7ssh-1.3.1-3.fc11.src.rpm
ne7ssh-1.3.1-3.fc11.src.rpm-BUMP_RELEASE_FORGOTTEN 
S.5.......T ne7ssh.spec

$ diff -u a/ne7ssh.spec b/ne7ssh.spec 
...
-cmake .
+CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" cmake .
...

This is the reason why the new package does not complain about
debuginfo-without-sources anymore.

Btw. it is also good practice to include the output of rpmlint everytime you
create a new package (I forget that sometimes too). This helps you to find bugs
before posting the new version and also helps reviewers etc. as a first
impression.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.