[Bug 225942] Merge Review: jdepend
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jan 8 22:43:42 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225942
Orion Poplawski <orion at cora.nwra.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |akurtako at redhat.com,
| |orion at cora.nwra.com
AssignedTo|nobody at fedoraproject.org |orion at cora.nwra.com
Flag| |fedora-review?
--- Comment #1 from Orion Poplawski <orion at cora.nwra.com> 2010-01-08 17:43:40 EDT ---
* rpmlint
jdepend.spec:38: W: non-standard-group Development/Libraries/Java
- I don't think this matters
jdepend.spec:53: W: non-standard-group Development/Documentation
- Think we'er using "Documentation" now.
jdepend.spec:63: W: non-standard-group Development/Libraries/Java
jdepend.spec:70: W: rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
- not needed
jdepend.spec: W: no-cleaning-of-buildroot %install
- but needed here
jdepend.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 35, tab: line 31)
* naming - check
* NamingGuidelines
* licensing BSD
* osi approved? yes
* included? yes
* correct mentioned in specfile? yes
specfile
* American English - yes
* legible - yes
* ExcludeArch, blocking - na
* BuildRequires - yes
* Locales - na
* shared libraries: ldconfig - na
* %clean section with rm -rf ${RPM_BUILD_ROOT} - yes
* macros -
* sources - check
* relocatable? Prefix: /usr? - na
* files and directories
- Guidelines use unversioned directory for javadoc now
* owns all created directories - yes
* all files listed in %files
* permissions?
* deffattr? - yes
* no .la files - yes
* .desktop for GUI applications - na
* no conflicts with other packets - yes
* permissable content - yes
* doc - yes
* large doc in -doc package - na
* must not affect runtime - yes
* sane scriptlets
- No longer need:
# for /bin/rm and /bin/ln
Requires(post): coreutils
Requires(postun): coreutils
* subpackages with fully versioned dependency -
- Guidelines specify that the javadoc package require the main package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Fedora-package-review
mailing list