[feedhenry-dev] Looking for someone with fh-mbaas-express knowledge

[David Ffrench]

Hi All,

After modifying the code weeks ago, i finally have time to come back and
manually test this change E2E. I have tested the multer changes with the
forms endpoints and it is working as expected. Unfortunately i have not
been able to find what uses the following endpoints for file upload. I am
hoping someone else will know.

*Does anyone know what uses these endpoints in `fh-mbaas-express` for file
upload?*
- https://github.com/feedhenry/fh-mbaas-express/blob/master/
lib/cloud/cloud.js#L45
- https://github.com/feedhenry/fh-mbaas-express/blob/master/
lib/mbaas.js#L173

Kind Regards,

DAVID FFRENCH

senior software engineer, RED HAT MOBILE

Red Hat Waterford <https://www.redhat.com/>

Communications House, Cork Road

Waterford, Ireland

dffrench at redhat.com
<https://red.ht/sig>


On Mon, Oct 16, 2017 at 8:39 AM, David Ffrench <dffrench at redhat.com> wrote:

> Thank you very much for the response John, your information is extremely
> helpful.
>
> DAVID FFRENCH
>
> senior software engineer, RED HAT MOBILE
>
> Red Hat Waterford <https://www.redhat.com/>
>
> Communications House, Cork Road
>
> Waterford, Ireland
>
> dffrench at redhat.com
> <https://red.ht/sig>
>
>
> On Fri, Oct 13, 2017 at 9:37 AM, John Frizelle <jfrizell at redhat.com>
> wrote:
>
>> Hi David,
>>
>> I have had a look through the code and as far as I can tell, the changes
>> are relatively straight forward. There are 3 places where an additional
>> parameter is required in a route definition:
>>
>> - https://github.com/feedhenry/fh-mbaas-express/blob/master/li
>> b/cloud/cloud.js#L45
>> - https://github.com/feedhenry/fh-mbaas-express/blob/master/li
>> b/mbaas.js#L173
>> - https://github.com/feedhenry/fh-mbaas-express/blob/master/li
>> b/mbaas.js#L299
>>
>> In all 3 cases, we need to add upload.any() as the middle param - this
>> will put any uploaded files in a files array, which is what is expected
>> in the rest of the code [1].
>>
>> Regards,
>> John.
>>
>> [1] https://github.com/feedhenry/fh-mbaas-express/blob/
>> master/lib/cloud/params.js#L42, https://github.com/feedhenry
>> /fh-mbaas-express/blob/master/lib/common/requestValidator.js#L111,
>> https://github.com/feedhenry/fh-mbaas-express/
>> blob/master/lib/fh-middleware.js#L25, https://github.com/
>> feedhenry/fh-mbaas-express/blob/master/lib/cloud/cloud.js#L69
>>
>>
>> --
>> John Frizelle
>> Chief Architect, Red Hat Mobile
>> Consulting Engineer
>>
>> mobile: *+353 87 290 1644 <//+353872901644>*
>> twitter:* @johnfriz*
>> skype: *john_frizelle*
>> mail: *jfrizell at redhat.com <jfrizell at redhat.com>*
>>
>>
>>
>>
>> On 12 October 2017 at 17:54, David Ffrench <dffrench at redhat.com> wrote:
>>
>>> Hi All,
>>>
>>> I am looking to talk to someone with a high knowledge of the
>>> https://github.com/feedhenry/fh-mbaas-express codebase. Specifically
>>> around the use of the multer module.
>>>
>>> Due to a security vulnerability, i need to upgrade the version of multer
>>> from 0.1.8 to 1.0.0 which breaks the app due to a breaking change in the
>>> multer api. This will require code modifications in fh-mbaas-express to
>>> resolve.
>>>
>>> There are only 2 locations in the app that multer is used but due to the
>>> way it's api has changed, there could be more code modifications required.
>>>
>>> Any help of guidance would be greatly appreciated.
>>>
>>> Best Regards,
>>>
>>> DAVID FFRENCH
>>>
>>> senior software engineer, RED HAT MOBILE
>>>
>>> Red Hat Waterford <https://www.redhat.com/>
>>>
>>> Communications House, Cork Road
>>>
>>> Waterford, Ireland
>>>
>>> dffrench at redhat.com
>>> <https://red.ht/sig>
>>>
>>>
>>> _______________________________________________
>>> feedhenry-dev mailing list
>>> feedhenry-dev at redhat.com
>>> https://www.redhat.com/mailman/listinfo/feedhenry-dev
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/feedhenry-dev/attachments/20171109/65f024d3/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.png
Type: image/png
Size: 11472 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/feedhenry-dev/attachments/20171109/65f024d3/attachment.png>