[sos-devel] Writing sos plugin for SQL Server on Linux

[Takayoshi Tanaka]

Thanks all,

I have updated the code based on your advice.
https://github.com/tanaka-takayoshi/sos/blob/mssql/sos/plugins/mssql.py

After I complete some tests, I'll make a pull request to GitHub.

On Thu, May 24, 2018 at 9:43 PM, Bryn M. Reeves <bmr at redhat.com> wrote:

> On Thu, May 24, 2018 at 01:03:16PM +0200, Pavel Moravec wrote:
> > Creating PR directly is IMHO fine, you can get better feedback there
> > pinpointing to particular lines etc. - a code review is better to be done
> > in github PR than via mail.
>
> We allow either ;)
>
> Personally, I'm a bit sad that everything has shifted to GitHub,
> because I think that email provides a more natural format to have
> a conversation: no vanishing diffs, no "outdated comments".. just
> good ol' fashioned email.
>
> > - instead of pure URL with mssql.conf format, it is (also) worth
> explaining
> > what the further code performs
>
> I'm not sure the URL is actually all that useful here; it's an INI
> file from which we want to obtain two keys.
>
> If anything just a brief comment explaining those two keys would
> seem sufficient.
>
> Regards,
> Bryn.
>
>


-- 

TAKAYOSHI TANAKA

SOFTWARE MAINTENANCE ENGINEER, RHCA, MICROSOFT MVP

Red Hat K.K. <https://www.redhat.com/>

8F, Ebisu Neonato, 4-1-18 Ebisu

Shibuya-ku Tokyo, 150-0013, Japan

tatanaka at redhat.com    M: +81-80-4193-5143     IM: tatanaka
<https://red.ht/sig>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/sos-devel/attachments/20180528/ee7b6d5d/attachment.htm>